search

cloudflare / pingora

A library for building fast, reliable and evolvable network services.
Apache License 2.0
20.25k stars 1.1k forks source link

Finish TODO: zip #214

Closed cospectrum closed 1 month ago

johnhurt commented 2 months ago

~This looks like excellent work! There's a lot going on in this pr. My recommendation is to break it down in to a few smaller prs tackling one todo at a time. Also make sure your commit doesn't include changes to the .bleep file. That's our marker for keeping this repo in sync with our working copy.~

Edit. Oops, ignore the above. I think this commit just needs to be rebased on the new main branch. We had an issue last week where all the commits form contributors got squashed and we had to fix it manually. The actual code change here looks great 👍

cospectrum commented 2 months ago

Rebased

johnhurt commented 2 months ago

Love it. Thanks!

eaufavor commented 1 month ago

Now available in https://github.com/cloudflare/pingora/commit/4347ef447183a66508c4de649a0657d1ce367dab. Thanks!