search

cloudflare / pingora

A library for building fast, reliable and evolvable network services.
Apache License 2.0
20.25k stars 1.1k forks source link

Add `Service<HttpProxy<T>>` constructor for providing name #218

Closed jamesmunns closed 1 month ago

jamesmunns commented 2 months ago

This adds a constructor that provides the Service name. This is used in river for naming the proxy services.

It would be possible to avoid this new constructor, however HttpProxy::new() is private, so I went with this to be consistent. I would also be happy to have direct access to the HttpProxy constructor.

This is currently needed for the 0.2 release of river.

eaufavor commented 1 month ago

Here we go https://github.com/cloudflare/pingora/commit/880488987c610317993ca76bd4b4b97991c3848e.