`ServerConf` documentation should make clear that `error_log` and `pid_file` are only used in background

cloudflare / pingora

A library for building fast, reliable and evolvable network services.

Apache License 2.0

20.25k stars 1.1k forks source link

`ServerConf` documentation should make clear that `error_log` and `pid_file` are only used in background #234

Closed palant closed 1 week ago

palant commented 1 month ago

Describe the bug

I tried using error_log and pid_file settings in the config file which didn’t seem to have any effect. It took searching the codebase to realize that these settings are only used if the process is daemonized.

Pingora info

Pingora version: 0.1.1

Additional context

ServerConf documentation