search

cloudflare / pingora

A library for building fast, reliable and evolvable network services.
Apache License 2.0
20.25k stars 1.1k forks source link

Fixes #235 - Replace unmaintained structopt crate by clap #239

Closed palant closed 1 month ago

palant commented 1 month ago

See #235 for the rationale. The change itself is pretty straightforward, the only issue here: existing code will have to be adapted (typically a trivial structopt::StructOpt => clap::Parser and Opt::from_args => Opt::parse search&replace).

A bunch of tests are failing for me, but that’s unchanged from current main branch.

palant commented 1 month ago

Concerning the clippy warning I fixed: that’s unrelated to my change. The only reason this issue wasn’t flagged on main is that the check was running Rust 1.77.2 there, and this warning is new in Rust 1.78.

johnhurt commented 1 month ago

Awesome. We merged this change internally, but had to go to an clap 3.x to maintain our minimum rust version. It will show up in the next internal -> external sync. Thanks!

drcaramelsyrup commented 1 month ago

Thanks for contributing! This was merged into main in 795594db83cf30dee3ba6955f17bc1334f03d41b (aforementioned adjustment in 9dee8e6775d95c9e5a28e7602a1232a94ee1f1d7).