search

cloudflare / pingora

A library for building fast, reliable and evolvable network services.
Apache License 2.0
20.64k stars 1.12k forks source link

Typo in https://blog.cloudflare.com/pingora-open-source: `UDP` should be `UDS` #25

Closed yerke closed 4 months ago

yerke commented 5 months ago

Describe the bug

First of all, congratulations on open sourcing Pingora and thank you for continuing to work on it!

In the linked blog post, you mention that Pingora works with UDP.

Pingora provides libraries and APIs to build services on top of HTTP/1 and HTTP/2, TLS, or just TCP/UDP.

I read relevant sections of Pingora source code, and I believe you made a typo. I think instead of UDP (User Datagram Protocol) you meant UDS (Unix domain socket). For example, HttpPeer can be constructed with TCP or UDS. Another example: SocketAddr is an enum over Inet(StdSockAddr) and Unix(StdUnixSockAddr).

Pingora info

N/A

Steps to reproduce

Search source for UDP and UDS.

Expected results

Find references to UDP.

Observed results

Only found references to UDS.

Additional context

N/A

drcaramelsyrup commented 4 months ago

The blog has been corrected. Thanks for bringing this up.