search

cloudflare / pingora

A library for building fast, reliable and evolvable network services.
Apache License 2.0
20.64k stars 1.12k forks source link

Fix build on FreeBSD #28

Closed yonas closed 3 months ago

yonas commented 5 months ago

Define group_id in the pingora-core's server daemon on FreeBSD.

Fixes #12

yonas commented 3 months ago

@johnhurt Why wasn't this committed?

Edit: Sorry I see you pushed 5fde29f

johnhurt commented 3 months ago

Sorry, I should have commented. We don't merge external PRs directly. Your commit was accepted and put into our internal repo a few days ago and then last Friday your commit got published into the main branch of this repository. I closed your pr because it is complete.