search

cloudflare / pingora

A library for building fast, reliable and evolvable network services.
Apache License 2.0
20.35k stars 1.1k forks source link

Add config for grace period and graceful shutdown timeout #99

Closed hnakamur closed 3 months ago

hnakamur commented 4 months ago

Fixes https://github.com/cloudflare/pingora/issues/98

andrewhavck commented 3 months ago

Do you mind updating the test here to initialize ServerConf with these new fields?

hnakamur commented 3 months ago

Oh sorry, I've updated the test. This time I confirmed the following test passes:

test server::configuration::tests::not_a_test_i_cannot_write_yaml_by_hand ... ok
andrewhavck commented 3 months ago

Thank you for your contribution, this has been synced.