Quiche drops the packet with the invalid stream id instead of sending CONNECTION_CLOSE

cloudflare / quiche

🥧 Savoury implementation of the QUIC transport protocol and HTTP/3

https://docs.quic.tech/quiche/

BSD 2-Clause "Simplified" License

9.4k stars 709 forks source link

Quiche drops the packet with the invalid stream id instead of sending CONNECTION_CLOSE #564

Open goelvidhi opened 4 years ago

goelvidhi commented 4 years ago

When we inject a stream frame with a stream ID larger than the max streams limit advertised by the QUIC library. The library must close the connection, with STREAM_LIMIT_ERROR.

Example (below stream is not permitted by the peer) STREAM[id=1157, off=0, len=100]

Currently, quiche drops the packet with the invalid stream id and keeps sending ping PTO probes.

LPardue commented 1 year ago

This is a bit of an oldie but I think via other changes and https://github.com/cloudflare/quiche/pull/1244 from @ehaydenr that this was actually fixed. Thoughts?