The config should be under provider property

cloudflare / serverless-cloudflare-workers

Serverless provider plugin for Cloudflare Workers

BSD 3-Clause "New" or "Revised" License

175 stars 37 forks source link

The config should be under provider property #1

Closed RaeesBhatti closed 6 years ago

RaeesBhatti commented 6 years ago

In the Serverless framework, the provider specific configuration is usually set under the provider property. It would be great if that practice is followed in the serverless-cloudflare-workers plugin as well. https://github.com/cloudflare/serverless-cloudflare-workers/blob/44a3addc73b73932263502b17aac0dcd0c927c37/provider/cloudflareProvider.js#L32

pinkerton commented 6 years ago

Good call. Will see about updating this.

RaeesBhatti commented 6 years ago

I've opened a PR that fixes the behavior in a backwards compatible way. Please let me know after a merge and new release of the package, so that, I can update templates in the framework.

pinkerton commented 6 years ago

Thanks. Please keep @rita3ko in the loop regarding templates and docs changes! We'll keep this updated on our end as well.