search

cloudflare / serverless-cloudflare-workers

Serverless provider plugin for Cloudflare Workers
BSD 3-Clause "New" or "Revised" License
175 stars 37 forks source link

Utilize node-cloudflare v2.5.1 for worker script upload #15

Closed webmasterkai closed 5 years ago

webmasterkai commented 5 years ago

Version 2.5.1 adds support for ZoneWorkers. Should that be used instead of cloudflare-workers-toolkit and cfApiCall within provider/sdk.js?

pseudo code:

const cloudflare = require('cloudflare')
const cf = cloudflare({
  email: process.env.CLOUDFLARE_AUTH_EMAIL,
  key: process.env.CLOUDFLARE_AUTH_KEY,
})
const updateWorkerScript = ({ zoneId, script }) => cf.zoneWorkersScript.edit(zoneId, script)
jspies commented 5 years ago

Workers is a newer product and has some beta features we want to take advantage of. The philosophy on node-cloudflare is to only support documented, generally released features.

It's probably something that will eventually get merged. cfApiCall should definitely be replaced with cloudflare-workers-toolkit though.