search

cloudflare / sslconfig

Cloudflare's Internet facing SSL configuration
BSD 3-Clause "New" or "Revised" License
1.3k stars 132 forks source link

Update NGINX SPDY patch for 1.9.15 #36

Open felixbuenemann opened 8 years ago

felixbuenemann commented 8 years ago

This updates the patch to work with NGINX 1.9.15 and also fixes a problem with the previous patch, that did not re-enable the spdy_* directives that were marked as deprecated by the http2 module as well as fixing a compile problem when the http2 module is enabled, but spdy is disabled.

injust commented 7 years ago

@lenovouser The patch linked by kn007 indeed works for 1.11.6.

lenovouser commented 7 years ago

@Injust nope, see cujanovic/nginx-http2-spdy-patch/issues/1 and

kn007 commented 7 years ago

@lenovouser I am upgrade Nginx to 1.11.6 withi this path last week, it's working.

kn007 commented 7 years ago

20161124072106

@lenovouser Do you using nginx-spdy-1.11.5+.patch, it's working well.

lenovouser commented 7 years ago

@kn007 weird, what NGINX source are you pulling from? I use https://nginx.org/download/nginx-1.11.6.tar.gz

kn007 commented 7 years ago

@lenovouser Yes, i am using http://nginx.org/download/nginx-1.11.6.tar.gz

lenovouser commented 7 years ago

Which one of the two files are you using? Because both are failing for me

kn007 commented 7 years ago

@lenovouser wget -c http://nginx.org/download/nginx-1.11.6.tar.gz tar zxvf nginx-1.11.6.tar.gz && cd nginx-1.11.6/ wget -c https://raw.githubusercontent.com/cujanovic/nginx-http2-spdy-patch/master/nginx-spdy-1.11.5%2B.patch patch -p1 < nginx-spdy-1.11.5+.patch

kn007 commented 7 years ago

@lenovouser 2016-11-24_075357

lenovouser commented 7 years ago

So weird. Works on my local machine, but the Docker container I am trying to build it in fails. Well. Seems like I have to go find out the bug myself. Thanks for your help!

kn007 commented 7 years ago

@lenovouser You are welcome, good luck!

lenovouser commented 7 years ago

So, I found the issue. In case anyone reads this in the future and you're using Alpine Linux, just do a apk add patch. That will update the patch binary. For some reason the one installed by default is buggy 😞

felixbuenemann commented 7 years ago

@lenovouser It's probably using a busybox version of patch by default.

pankajslingwal commented 4 years ago

So, I found the issue. In case anyone reads this in the future and you're using Alpine Linux, just do a apk add patch. That will update the patch binary. For some reason the one installed by default is buggy 😞

dude, you saved my day :)