cloudflare / sslconfig

Cloudflare's Internet facing SSL configuration
BSD 3-Clause "New" or "Revised" License
1.3k stars 132 forks source link

About NGX_SSL_MAX_SESSION_SIZE in nginx__dynamic_tls_records.patch #55

Open rfnx opened 7 years ago

rfnx commented 7 years ago

Hello,

In nginxdynamic_tls_records.patch, the change made at line 139 (https://github.com/cloudflare/sslconfig/blob/master/patches/nginxdynamic_tls_records.patch#L139) seems unrelated to the patch for dynamic record size. I don't know much about nginx programming but the define NGX_SSL_MAX_SESSION_SIZE is never used in the patch.

Same thing in the new patch for nginx 1.11.5, at line 124 : https://github.com/cloudflare/sslconfig/blob/master/patches/nginx__1.11.5_dynamic_tls_records.patch#L124