Closed olebedev closed 3 months ago
PR merged. Thank you!
Great, thank you @buffer for your swift response!
Can you guide me through the project's release process? I'm interested in understanding how to make it available on PyPI.
The release process is extremely simple and relies on Github Actions.
The YAML files in the folder .github/workflows take care of building STPyV8 every time a patch is committed and run tests once done to spot issues and regressions. This process is performed on all the supported platforms. Moreover every time a specific version of Google V8 is built on a specific platform the V8 binary is cached so that it is not built again and again thus saving time.
The release process to PyPI is fired just when I manually create a new Github release. This is done intentionally and allows me to have full control of the release process as there could be situations where I want to create a git tag but not to release STPyV8 to PyPI
Hi there 👋,
I tried to use the package and encountered issues with the published wheels.
I turned out that the metadata is inaccurate which led to the wheel's lookup miss. And later, for the fallback of building the package it relies on the
wheel
package which cannot be found during the build process due to it's not listed in thesetup_requires
argument.In this PR I suggest the change that fixes both issue. Please let me know what are your thoughts. I am open for discussion around find the best approach to address the issue.
Kind regards, Oleg