search

cloudflare / templates

A collection of starter templates and examples for Cloudflare Workers and Pages
https://cloudflareworkers.com
MIT License
1k stars 637 forks source link

Fix build command? #159

Closed DougAnderson444 closed 1 year ago

DougAnderson444 commented 1 year ago

Shouldn't the build command be: cargo build ? (and not npm run build)

JacobMGEvans commented 1 year ago

npm run build in the Wrangler environment is used to kick off a custom build step which can involve anything including some good ole' Rust steps. Thank you for the PR and for reference future Template work will be conducted in workers-sdk monorepo where the templates have been moved https://github.com/cloudflare/workers-sdk/tree/main/templates

DougAnderson444 commented 1 year ago

Oh thank you for pointing out the new ask repo! I'm sure that will answer a lot of questions I was having with the legacy repo.

On Tue., Feb. 14, 2023, 6:09 p.m. Jacob M-G Evans, @.***> wrote:

npm run build in the Wrangler environment is used to kick off a custom build step which can involve anything including some good ole' Rust steps. Thank you for the PR and for reference future Template work will be conducted in workers-sdk monorepo where the templates have been moved https://github.com/cloudflare/workers-sdk/tree/main/templates

— Reply to this email directly, view it on GitHub https://github.com/cloudflare/templates/pull/159#issuecomment-1430441253, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTDW7J75WQIOG3EP3VYLRTWXP7B3ANCNFSM6AAAAAAUPGHPLE . You are receiving this because you authored the thread.Message ID: @.***>