search

cloudflare / tls-tris

crypto/tls, now with 100% more 1.3. THE API IS NOT STABLE AND DOCUMENTATION IS NOT GUARANTEED.
Other
292 stars 50 forks source link

document what the Committer is supposed to do (or remove it) #131

Closed marten-seemann closed 6 years ago

marten-seemann commented 6 years ago

Committer is an interface that the Conn is type asserted against in https://github.com/cloudflare/tls-tris/blob/e20b4d2a9a269651cbd39fd66a40caa56d4c4130/13.go#L155-L159 There's no explanation what the purpose of this is, and also the definition of the interface in https://github.com/cloudflare/tls-tris/blob/e20b4d2a9a269651cbd39fd66a40caa56d4c4130/handshake_server.go#L19-L21 doesn't provide any clues.

Since this is a public interface tris exposes, it should either be properly documented, or removed.

Lekensteyn commented 6 years ago

It was added in ea17b0c2255db074941b16938f654029b12abd46 and moved in 0d97989e0d689bd976ede383b4db99feb5d9fe1f. My guess is that this mechanism would allow server to control whether a (replayed) 0-RTT handshake is okay or not.

For the lack of an actual implementation, it is probably fine to remove it.

kriskwiatkowski commented 6 years ago

This code doesn't seem to be useful for anything.