Improve testing - Githubissues

kriskwiatkowski commented 5 years ago

I would like to collect here ideas on how to improve testing. This is my current non-exhaustive list

run tests the library against multiple versions of Go
run tests the library against multiple versions of platform (amd64, arm, arm64 and on linux, windows and macOS). We should run those tests for all platforms we declare to support
Introduce code coverage
Use go-fuzz for fuzzing GH #65
Use only one docker container for interoperability testing: GH #157
Build debian package - mainly to ensure any change to Makefile won't break Cloudflare's internal build. Also it would be great to be able to install go with tris from a package
Introduce code coverage
Benchmarking, to ensure there is no performance degradation (if that's possible)
Can we do symbolic execution with something which has similar functionality to KLEE?

Lekensteyn commented 5 years ago

Right now it does not build on macOS due to issues in the Makefile with sed and cp, I'm working on that.

However it also seems that 1.12 moved some packages since chacha20poly1305 is no longer under a golang_org folder. Compare 1.12.1 on macOS: /usr/local/Cellar/go/1.12.1/libexec/src/internal/x/crypto/chacha20poly1305 /usr/share/go-1.12/src/internal/x/crypto/chacha20poly1305 (golang-1.12-src in Debian sid)

to go 1.11.6: /usr/share/go-1.11/src/vendor/golang_org/x/crypto/chacha20poly1305

kriskwiatkowski commented 5 years ago

Thanks for reporting ! I don't think it has ever been tested with 1.12

Lekensteyn commented 5 years ago

I have opened #166 to track the Go 1.12 issue. Go 1.13 has changed things again, possibly due to Go modules.

cloudflare / tls-tris

Improve testing #165