search

cloudflare / tls-tris

crypto/tls, now with 100% more 1.3. THE API IS NOT STABLE AND DOCUMENTATION IS NOT GUARANTEED.
Other
291 stars 51 forks source link

Vendoring issues with SIKE and SIDH #177

Closed Lekensteyn closed 5 years ago

Lekensteyn commented 5 years ago

We currently rename import paths for github.com/henrydcase/nobs and github.com/cloudflare/sidh from github.com to github_com to avoid errors such as:

can't load package: .../crypto/tls/13.go:24:2: non-standard import "github.com/cloudflare/sidh/sidh" in standard package "crypto/tls"

Since Go 1.13, non-standard import paths in $GOROOT/src are resolved with the vendor directory in $GOROOT/src/vendor, see https://github.com/golang/go/commit/fd080ea3bcc2, so this rename can be undone.

For Go 1.12 and before, we might have to find an alternative solution. Right now some projects that use go build -mod=vendor fail with:

make: Nothing to be done for 'go'.
.../_dev/GOROOT/linux_amd64/src/crypto/tls/13.go:24:2: cannot find package "." in:
    <other project>/vendor/github_com/cloudflare/sidh/sidh
.../_dev/GOROOT/linux_amd64/src/crypto/tls/13.go:25:2: cannot find package "." in:
    <other project>/vendor/github_com/cloudflare/sidh/sike

Addressing this issue potentially fixes #175 as well.