search

cloudflare / tls-tris

crypto/tls, now with 100% more 1.3. THE API IS NOT STABLE AND DOCUMENTATION IS NOT GUARANTEED.
Other
292 stars 50 forks source link

tris: fix nonce length definition and actually use it #56

Closed Lekensteyn closed 6 years ago

Lekensteyn commented 6 years ago

All TLS 1.3 cipher suites so far use a nonce length of 12, but that does not have to be the case. Correct the cipher suite definition and use it. Spec: https://tools.ietf.org/html/draft-ietf-tls-tls13-22#section-5.3

Note: there is no functional change, the values were previously unused.

Fixes: ("[dev.tls] crypto/tls: implement TLS 1.3 cipher suites")

Reported in https://github.com/bifurcation/mint/issues/142

Lekensteyn commented 6 years ago

Thanks for reviewing, merged into 759dbb355afa6c37ae9df7f9fdc864d80d45111f