search

cloudflare / wildebeest

Wildebeest is an ActivityPub and Mastodon-compatible server
Other
2.04k stars 399 forks source link

Migration step fails but shows as successful run in Action UI #343

Closed sterlingwes closed 1 year ago

sterlingwes commented 1 year ago

Was getting "timeline cannot be loaded, please try again" when I tried to load the site after deploy and couldn't figure out why. Turns out the database was empty! Even though the deploy job seemed to finish fine first time around:

Screenshot 2023-02-25 at 6 09 14 PM Screenshot 2023-02-25 at 6 09 24 PM

Looks like the d1 migrations command doesn't exit with a non-zero?

The fix for me was to pull out the migration steps in a separate workflow so I could run it again (https://github.com/cloudflare/wildebeest/compare/main...sterlingwes:wildebeest:fix/migration)

xtuc commented 1 year ago

Intermittent D1 error, should fix itself after a rerun (which is what your change did).

sterlingwes commented 1 year ago

@xtuc the issue is that the error doesn't manifest as a GH action run failure, which is the actual issue here

sterlingwes commented 1 year ago

@xtuc this is still an issue

should i open this on the wrangler repo? unclear to me where this exit code is getting swallowed