Open sterlingwes opened 1 year ago
left a few comments regarding tailing, by the way thanks a bunch @sterlingwes :smiley:
Updated! hope that works. thanks for the weekend review 🙏🏻
Updated! hope that works. thanks for the weekend review 🙏🏻
No problem, thank you very much for contributing! :smiley:
Ready to merge, just one small last thing, could you squash the commits into one? :pray:
Updated! hope that works. thanks for the weekend review 🙏🏻
No problem, thank you very much for contributing! 😃
Ready to merge, just one small last thing, could you squash the commits into one? 🙏
Can you use capital letters and punctionation in the bullets for consistency with the rest of the documentation?
You should really consider changing the default to squash on merge so that force pushing on branches during a review isn't necessary
from my other PR:
have you considered changing the default for the repo to squash on merge? That seems to be the standard nowadays since it encourages PRs to be about one thing (leading to one commit on main, but still allowing for granular commits on the branch and not interrupting the review with force pushes) which is a good practice
Also lowers the contribution barrier to entry.. i find myself less enthused about contributing anything substantial to this repo when it's so much back and forth over smol readme changes
Found it really hard to get basic info on why I was seeing an error page when I loaded the app. Figure these steps might be useful. Would love any tips on how to get the deployment ID in a nicer way than directing them to guess at UDIDs in the URL bar!
These steps helped me get at the problem caused by https://github.com/cloudflare/wildebeest/issues/343