search

cloudflare / worker-sites-init

tropical irradiation
Apache License 2.0
2 stars 5 forks source link

Update @cloudflare/kv-asset-handler #6

Open minddust opened 4 years ago

minddust commented 4 years ago

template version 0.0.5 doesn't support serveSinglePageApp.

current available version: 0.0.7

ashleymichal commented 4 years ago

using ^0.0.5 should be allowing it to adapt all the way up to 1.0.0, however checking in package.lock means that we pin unintentionally (I believe).

ashleymichal commented 4 years ago

@minddust i think your problem can be solved by removing your local package.lock file and re-running npm install. in the meantime we'll discuss whether it makes sense to continue committing the package.lock file to this repo.

minddust commented 4 years ago

i know how to fix stuff, that's not the issue. it's to stay up-to-date or to remove the lock as you suggested ;) makes it easier for starters not to struggle with a legacy version

ashleymichal commented 4 years ago

understood! i always try to provide the unblock suggestion if only to benefit the next user who stumbles upon this issue 😃

kristianfreeman commented 4 years ago

i think we should bump the package version and keep package-lock.json! afaik that's the right way to do this ~cc @ashleygwilliams as she will probably know the definitive answer~ talked to IRL, this is her suggested approach too 👍

abury commented 4 years ago

I've been struggling to get this to work. After bumping the version number to 0.0.7 manually wrangler publish/dev explodes saying it can't find @cloudflare/kv-asset-handler). I'll open a separate ticket for this