search

cloudflare / worker-sites-init

tropical irradiation
Apache License 2.0
2 stars 5 forks source link

Updating @cloudflare/kv-asset-handler to 0.0.8 causes wrangler command to fail #8

Closed abury closed 4 years ago

abury commented 4 years ago

Hey Cloudflare workers team

I've been trying to get routing to work properly on my react app and came across serveSinglePageApp in the later versions of @cloudflare/kv-asset-handler, however after manually bumping them to the latest version and installing, I get the following error after wrangler publish 

👀  ./workers-site/index.js
Module not found: Error: Can't resolve '@cloudflare/kv-asset-handler' in '/Users/user/Documents/Apps/React/Projects/appName/workers-site'
resolve '@cloudflare/kv-asset-handler' in '/Users/user/Documents/Apps/React/Projects/appName/workers-site'
  Parsed request is a module
  using description file: /Users/user/Documents/Apps/React/Projects/appName/workers-site/package.json (relative path: .)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      /Users/user/Documents/Apps/React/Projects/node_modules doesn't exist or is not a directory
      /Users/user/Documents/Apps/React/node_modules doesn't exist or is not a directory
      /Users/user/Documents/Apps/node_modules doesn't exist or is not a directory
      /Users/user/Documents/node_modules doesn't exist or is not a directory
      /Users/user/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
      looking for modules in /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules
        using description file: /Users/user/Documents/Apps/React/Projects/appName/workers-site/package.json (relative path: ./node_modules)
          Field 'browser' doesn't contain a valid alias configuration
      looking for modules in /Users/user/Documents/Apps/React/Projects/appName/node_modules
        using description file: /Users/user/Documents/Apps/React/Projects/appName/package.json (relative path: ./node_modules)
          Field 'browser' doesn't contain a valid alias configuration
          using description file: /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/package.json (relative path: .)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler is not a file
            .wasm
              Field 'browser' doesn't contain a valid alias configuration
          using description file: /Users/user/Documents/Apps/React/Projects/appName/package.json (relative path: ./node_modules/@cloudflare/kv-asset-handler)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.wasm doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler doesn't exist
            .wasm
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.mjs doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.wasm doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.js doesn't exist
            .json
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.mjs doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.json doesn't exist
              /Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.js doesn't exist
            .json
              Field 'browser' doesn't contain a valid alias configuration
            as directory
              existing directory
                use ./dist/index.js from main in package.json
                  using description file: /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/package.json (relative path: .)
                    Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.json doesn't exist
            as directory
              /Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler doesn't exist
                    using description file: /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/package.json (relative path: ./dist/index.js)
                      no extension
                        Field 'browser' doesn't contain a valid alias configuration
                        /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js doesn't exist
                      .wasm
                        Field 'browser' doesn't contain a valid alias configuration
                        /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.wasm doesn't exist
                      .mjs
                        Field 'browser' doesn't contain a valid alias configuration
                        /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.mjs doesn't exist
                      .js
                        Field 'browser' doesn't contain a valid alias configuration
                        /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.js doesn't exist
                      .json
                        Field 'browser' doesn't contain a valid alias configuration
                        /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.json doesn't exist
                      as directory
                        /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js doesn't exist
                using path: /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index
                  using description file: /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/package.json (relative path: ./index)
                    no extension
                      Field 'browser' doesn't contain a valid alias configuration
                      /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index doesn't exist
                    .wasm
                      Field 'browser' doesn't contain a valid alias configuration
                      /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.wasm doesn't exist
                    .mjs
                      Field 'browser' doesn't contain a valid alias configuration
                      /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.mjs doesn't exist
                    .js
                      Field 'browser' doesn't contain a valid alias configuration
                      /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.js doesn't exist
                    .json
                      Field 'browser' doesn't contain a valid alias configuration
                      /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.json doesn't exist
[/Users/user/Documents/Apps/React/Projects/node_modules]
[/Users/user/Documents/Apps/React/node_modules]
[/Users/user/Documents/Apps/node_modules]
[/Users/user/Documents/node_modules]
[/Users/user/node_modules]
[/Users/node_modules]
[/node_modules]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.wasm]
[/Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.mjs]
[/Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.wasm]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.js]
[/Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.mjs]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.json]
[/Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.js]
[/Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.json]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.wasm]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.mjs]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.js]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.json]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.wasm]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.mjs]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.js]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.json]
 @ ./workers-site/index.js 1:0-80 44:17-31 49:37-51 71:26-43
Error: webpack returned an error. You may be able to resolve this issue by running npm install.

Not entirely sure if this is an issue with KV asset handler, this repo or wrangler 🤷‍♂️

EverlastingBugstopper commented 4 years ago

Hey @abury - it would be helpful if there was a repository we could reproduce this with. There are two things off the top of my head I think it might be

If it's not either of those things, I'll need more information to troubleshoot.

abury commented 4 years ago

Hey @EverlastingBugstopper, yeah I tried running npm install from within the workers-site directory as well, no dice. Note that this is only happening with 0.0.8 (where it looks like you added in TS) 0.0.7 works fine. This is with a CRA, so it's just using the standard webpack config from that. I'll see if I can get a repo going for you today

EverlastingBugstopper commented 4 years ago

Oh - maybe try updating to 0.0.9? That may fix your issue, will need to remove node_modules and update to ^0.0.9 in package.json and reinstall

abury commented 4 years ago

@EverlastingBugstopper yep! 0.0.9 works a treat 👍