search

cloudflare / worker-template-router

231 stars 85 forks source link

serverless-cloudflare-workers is an unused dependency #28

Closed jahands closed 4 years ago

jahands commented 4 years ago

Why is this included as a dependency when it isn't used? Unless I'm missing something, the code works just fine with it not included.

nikhiljohn10 commented 4 years ago

That is a true. It have nothing to do with worker code. But I think that it is added as an optional for users who need to use serverless deployment method.

jahands commented 4 years ago

Makes sense. I'm new to npm so I was confused but I'm sure experienced users will know they can remove it. Maybe it should be noted in the readme that it can be removed if you aren't using that deployment method? Especially now that a good alternative exists for deploying to Workers (wrangler).

nikhiljohn10 commented 4 years ago

i have made an updated version of this template - API Worker Template or you can try more this one if you need to use as npm module in wrangler project.

jahands commented 4 years ago

Oh hey thanks! The module is actually exactly what I want! I'll go ahead and close this.