search

cloudflare / workers-sdk

⛅️ Home to Wrangler, the CLI for Cloudflare Workers®
https://developers.cloudflare.com/workers/
Apache License 2.0
2.68k stars 701 forks source link

🐛 BUG: CTRL +C sometimes doesn't cancel operations with C3 #3318

Closed Cherry closed 1 year ago

Cherry commented 1 year ago

Which Cloudflare product(s) does this pertain to?

C3

What version of Wrangler are you using?

c3 2.0.7

What operating system are you using?

Windows 10

Describe the Bug

It will deploy anyway.

This also happens when being asked about TypeScript when doing a hello world - hitting CTRL + C just proceeds and doesn't cancel.

jculvey commented 1 year ago

This was fixed by https://github.com/cloudflare/workers-sdk/pull/3525 and will be included in 2.0.12.

The root cause here was that the confirm and select inputs weren't correctly handling the cancel state of clack prompts.