🚀 Feature Request: Add C3 proper git e2e testing

cloudflare / workers-sdk

⛅️ Home to Wrangler, the CLI for Cloudflare Workers®

https://developers.cloudflare.com/workers/

Apache License 2.0

2.72k stars 713 forks source link

Open dario-piotrowicz opened 1 year ago

dario-piotrowicz commented 1 year ago

The current C3 e2e tests don't check the git initialization

They should check:

whether or not a git repository has been initialized when requested
that appropriate commit/commits have been generated (note: in #3776 a commit message check has been added but that only related on the commit message passed to wrangler pages deploy via --commit-message and is not checking that commit actually exists)

jculvey commented 7 months ago

@dario-piotrowicz is this still relevant?

dario-piotrowicz commented 7 months ago

@jculvey yes 🙂 (since we still don't test in any way the git commands that C3 performs)