cloudflare / workers-sdk

⛅️ Home to Wrangler, the CLI for Cloudflare Workers®
https://developers.cloudflare.com/workers/
Apache License 2.0
2.6k stars 675 forks source link

Improve `runInDurableObject` type #6007

Closed Skye-31 closed 3 months ago

Skye-31 commented 3 months ago

What this PR solves / how to test

#5975 updated the type for runInDurableObject to infer the stub's type correctly for RPC methods, however it used the wrong DurableObjects type. This PR fixes the type used to properly support RPC methods.

Author has addressed the following

cc @RamIdeas

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: eb6801bdb6a20ca7abcba05b9e8f0bd12226bea2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------------- | ----- | | @cloudflare/vitest-pool-workers | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9468608428/npm-package-wrangler-6007

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6007/npm-package-wrangler-6007

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9468608428/npm-package-wrangler-6007 dev path/to/script.js
Additional artifacts: ```sh npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9468608428/npm-package-create-cloudflare-6007 --no-auto-update ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9468608428/npm-package-cloudflare-kv-asset-handler-6007 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9468608428/npm-package-miniflare-6007 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9468608428/npm-package-cloudflare-pages-shared-6007 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9468608428/npm-package-cloudflare-vitest-pool-workers-6007 ``` Note that these links will no longer work once [the GitHub Actions artifact expires](https://docs.github.com/en/organizations/managing-organization-settings/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-organization).

wrangler@3.60.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240605.0
workerd 1.20240605.0 1.20240605.0
workerd --version 1.20240605.0 2024-06-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

holopin-bot[bot] commented 3 months ago

Congratulations @Skye-31, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxbp75p449020cl6zf19r92n

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!