cloudflare / workers-sdk

⛅️ Home to Wrangler, the CLI for Cloudflare Workers®
https://developers.cloudflare.com/workers/
Apache License 2.0
2.6k stars 675 forks source link

fix: reduce the number of parallel file reads on Windows to avoid EMFILE type errors #6009

Closed RamIdeas closed 3 months ago

RamIdeas commented 3 months ago

What this PR solves / how to test

Reapplies the batching reverted in https://github.com/cloudflare/workers-sdk/pull/6002 but with a tested helper method to ensure batches are correctly compiled

Author has addressed the following

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: f9199083a2318a8ebb2a0444d551a71e108c94e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------------- | ----- | | wrangler | Patch | | @cloudflare/vitest-pool-workers | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-wrangler-6009

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6009/npm-package-wrangler-6009

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-wrangler-6009 dev path/to/script.js
Additional artifacts: ```sh npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-create-cloudflare-6009 --no-auto-update ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-cloudflare-kv-asset-handler-6009 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-miniflare-6009 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-cloudflare-pages-shared-6009 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-cloudflare-vitest-pool-workers-6009 ``` Note that these links will no longer work once [the GitHub Actions artifact expires](https://docs.github.com/en/organizations/managing-organization-settings/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-organization).

wrangler@3.60.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240605.0
workerd 1.20240605.0 1.20240605.0
workerd --version 1.20240605.0 2024-06-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

holopin-bot[bot] commented 3 months ago

Congratulations @RamIdeas, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxc80u4s12320cl7w3k99jbv

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!