cloudflare / workers-sdk

⛅️ Home to Wrangler, the CLI for Cloudflare Workers®
https://developers.cloudflare.com/workers/
Apache License 2.0
2.42k stars 594 forks source link

test: add checks of uploads of very large number of Pages assets #6010

Closed petebacondarwin closed 3 weeks ago

petebacondarwin commented 3 weeks ago

What this PR solves / how to test

Adds a test to avoid accidentally breaking Pages uploads for large numbers of assets.

This test would have failed after the #5632 change.

Author has addressed the following

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: ea441c24c2ca362250e4cfc7cdfb53684fb811a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 3 weeks ago

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-wrangler-6010

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6010/npm-package-wrangler-6010

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-wrangler-6010 dev path/to/script.js
Additional artifacts: ```sh npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-create-cloudflare-6010 --no-auto-update ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-cloudflare-kv-asset-handler-6010 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-miniflare-6010 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-cloudflare-pages-shared-6010 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-cloudflare-vitest-pool-workers-6010 ``` Note that these links will no longer work once [the GitHub Actions artifact expires](https://docs.github.com/en/organizations/managing-organization-settings/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-organization).

wrangler@3.60.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240605.0
workerd 1.20240605.0 1.20240605.0
workerd --version 1.20240605.0 2024-06-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

holopin-bot[bot] commented 3 weeks ago

Congratulations @petebacondarwin, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxbju6d114510cmhpngtze5u

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

GregBrimble commented 3 weeks ago

Now we have the bot installed, I'm just testing Holopin really quickly here, sorry! Don't mind me!