cloudflare / workers-sdk

⛅️ Home to Wrangler, the CLI for Cloudflare Workers®
https://developers.cloudflare.com/workers/
Apache License 2.0
2.41k stars 593 forks source link

Normalize more dependencies. #6046

Closed threepointone closed 2 weeks ago

threepointone commented 2 weeks ago

Follow up to https://github.com/cloudflare/workers-sdk/pull/6029, this normalizes some more dependencies : get-port, chalk, yargs, toucan-js, @typescript-eslint/parser, @typescript-eslint/eslint-plugin, esbuild-register, hono, glob-to-regexp, @cloudflare/workers-types

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: ef96fa50a9755b178c69e9519af0b6cff3f88b9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | -------------------------------- | ----- | | edge-preview-authenticated-proxy | Patch | | playground-preview-worker | Patch | | workers-playground | Patch | | create-cloudflare | Patch | | turbo-r2-archive | Patch | | format-errors | Patch | | wrangler | Patch | | @cloudflare/vitest-pool-workers | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 weeks ago

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-wrangler-6046

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6046/npm-package-wrangler-6046

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-wrangler-6046 dev path/to/script.js
Additional artifacts: ```sh npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-create-cloudflare-6046 --no-auto-update ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-cloudflare-kv-asset-handler-6046 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-miniflare-6046 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-cloudflare-pages-shared-6046 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9520940244/npm-package-cloudflare-vitest-pool-workers-6046 ``` Note that these links will no longer work once [the GitHub Actions artifact expires](https://docs.github.com/en/organizations/managing-organization-settings/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-organization).

wrangler@3.60.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.0
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

threepointone commented 2 weeks ago

Thanks @dario-piotrowicz! But looks like I need someone from the wrangler team to stamp it :/ I'll wait, no rush.

dario-piotrowicz commented 2 weeks ago

Thanks @dario-piotrowicz! But looks like I need someone from the wrangler team to stamp it :/ I'll wait, no rush.

yeah, I saw that a C3 owner was also needed so I figured I might try to help 🙂

threepointone commented 2 weeks ago

Oh that's right. Thank you!

petebacondarwin commented 2 weeks ago

Added the e2e label to run those tests since this has potentially wide-ranging impact. If green we can land it.

threepointone commented 2 weeks ago

All the changes under /templates are an update to workers-types, and seem to be passing now. Later I'm going to add /templates under workspaces as well.

threepointone commented 2 weeks ago

Early next week, before we release, I'm going to do a whole bunch of testing of generated builds, so it'll be my fault if something broke here :)

threepointone commented 2 weeks ago

weird error. I'll have a look on monday. thanks for the late assists!

holopin-bot[bot] commented 2 weeks ago

Congratulations @threepointone, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxfi5j7u06510cmghecpybzb

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!