cloudflare / workers-sdk

⛅️ Home to Wrangler, the CLI for Cloudflare Workers®
https://developers.cloudflare.com/workers/
Apache License 2.0
2.41k stars 593 forks source link

fix: node compat v2 handle $ in inject preset #6048

Closed IgorMinar closed 2 weeks ago

IgorMinar commented 2 weeks ago

What this PR solves / how to test

Follow up on https://github.com/cloudflare/workers-sdk/pull/6025 that makes the code a bit more resilient.

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: 17828ed88565ea2bfa97a0665be064330c9e4de9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 2 weeks ago

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529448200/npm-package-wrangler-6048

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6048/npm-package-wrangler-6048

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529448200/npm-package-wrangler-6048 dev path/to/script.js
Additional artifacts: ```sh npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529448200/npm-package-create-cloudflare-6048 --no-auto-update ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529448200/npm-package-cloudflare-kv-asset-handler-6048 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529448200/npm-package-miniflare-6048 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529448200/npm-package-cloudflare-pages-shared-6048 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9529448200/npm-package-cloudflare-vitest-pool-workers-6048 ``` Note that these links will no longer work once [the GitHub Actions artifact expires](https://docs.github.com/en/organizations/managing-organization-settings/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-organization).

wrangler@3.60.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.0
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

petebacondarwin commented 2 weeks ago

And pushed a commit that should fix the lint errors and the failing tests

holopin-bot[bot] commented 2 weeks ago

Congratulations @IgorMinar, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxjby4zv06770cl2j4rvfupz

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!