cloudflare / workers-sdk

⛅️ Home to Wrangler, the CLI for Cloudflare Workers®
https://developers.cloudflare.com/workers/
Apache License 2.0
2.6k stars 674 forks source link

chore: change vitest config to be ESM (for sure) to avoid warnings #6055

Closed petebacondarwin closed 3 months ago

petebacondarwin commented 3 months ago

Without this we often see:

 The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 6ac391d3ae649a812167a8f3e9a6f4e50f6f7d77

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

threepointone commented 3 months ago

omg yes

github-actions[bot] commented 3 months ago

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9528989498/npm-package-wrangler-6055

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6055/npm-package-wrangler-6055

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9528989498/npm-package-wrangler-6055 dev path/to/script.js
Additional artifacts: ```sh npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9528989498/npm-package-create-cloudflare-6055 --no-auto-update ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9528989498/npm-package-cloudflare-kv-asset-handler-6055 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9528989498/npm-package-miniflare-6055 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9528989498/npm-package-cloudflare-pages-shared-6055 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9528989498/npm-package-cloudflare-vitest-pool-workers-6055 ``` Note that these links will no longer work once [the GitHub Actions artifact expires](https://docs.github.com/en/organizations/managing-organization-settings/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-organization).

wrangler@3.60.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.0
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

petebacondarwin commented 3 months ago

An alternative solution to changing the file name is to set "type": "module" in various package.json files but that seemed like a more dangerous change.

andyjessop commented 3 months ago

An alternative solution to changing the file name is to set "type": "module" in various package.json files but that seemed like a more dangerous change.

I wonder if it's worth doing just that, as a fail-fast mechanism. If users have "type": "module" and it breaks things, we likely want to know about it as soon as possible.

petebacondarwin commented 3 months ago

An alternative solution to changing the file name is to set "type": "module" in various package.json files but that seemed like a more dangerous change.

I wonder if it's worth doing just that, as a fail-fast mechanism. If users have "type": "module" and it breaks things, we likely want to know about it as soon as possible.

By dangerous change, I meant that switching the default format for the packages in our repo could have consequences outside of Vitest that I didn't want to start messing with. Not that we potentially don't support such packages.

FWIW the Vitest Pool Workers fixture tests all use this as the default already, so that is covered there.

holopin-bot[bot] commented 3 months ago

Congratulations @petebacondarwin, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxkbrwtp113070cl3plfonjyh

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!