Closed petebacondarwin closed 2 weeks ago
Latest commit: 25b8b866f981fc05bbf5c4b58ce0c4d40103bf99
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
A wrangler prerelease is available for testing. You can install this latest build in your project with:
npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9528821081/npm-package-wrangler-6057
You can reference the automatically updated head of this PR with:
npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6057/npm-package-wrangler-6057
Or you can use npx
with this latest build directly:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9528821081/npm-package-wrangler-6057 dev path/to/script.js
wrangler@3.60.3
includes the following runtime dependencies:
Package | Constraint | Resolved |
---|---|---|
miniflare |
workspace:* | 3.20240610.0 |
workerd |
1.20240610.1 | 1.20240610.1 |
workerd --version |
1.20240610.1 | 2024-06-10 |
Please ensure constraints are pinned, and miniflare
/workerd
minor versions match.
Congratulations @petebacondarwin, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxg8mmfy21810cl3ywdl8avs
This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!
What this PR solves / how to test
These tests create a fake package that relies upon the local versions of vitest-pool-workers and its dependencies. To make this work we package up all the local dependencies and add them to pnpm overrides.
Unfortunately we missed the transitive
@cloudflare/kv-asset-handler
dependency, so when that got a version bump the tests broke.This is the simple, naive fix - adding in this package to those being packed. We ought to find a better solution that doesn't require manual dependency tracking.
Author has addressed the following