search

cloudflare / workers-sdk

⛅️ Home to Wrangler, the CLI for Cloudflare Workers®
https://developers.cloudflare.com/workers/
Apache License 2.0
2.41k stars 593 forks source link

Update actions/upload-artifact from v3 to v4 #6065

Closed threepointone closed 2 weeks ago

threepointone commented 2 weeks ago

This removes the warning about it using an outdated version of node.

I don't think we need to make any changes here, but here's a reference https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: b83d9ce546f6417bb821d28f7ee419f99b588285

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 2 weeks ago

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9538305459/npm-package-wrangler-6065

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6065/npm-package-wrangler-6065

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9538305459/npm-package-wrangler-6065 dev path/to/script.js
Additional artifacts: ```sh npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9538305459/npm-package-create-cloudflare-6065 --no-auto-update ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9538305459/npm-package-cloudflare-kv-asset-handler-6065 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9538305459/npm-package-miniflare-6065 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9538305459/npm-package-cloudflare-pages-shared-6065 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9538305459/npm-package-cloudflare-vitest-pool-workers-6065 ``` Note that these links will no longer work once [the GitHub Actions artifact expires](https://docs.github.com/en/organizations/managing-organization-settings/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-organization).

wrangler@3.60.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.0
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

threepointone commented 2 weeks ago

ok, maybe not, the paths have to be changed. I'll leave it for next week.

threepointone commented 2 weeks ago

Closing this one because it's a little more fiddly.