fix: onBundleStart dependency array

[RamIdeas]

What this PR solves / how to test

Fixes extraneous item in onBundleStart dependency array. Addresses comment here.

This prop was left in the dependency array after removing a redundant surrounding if-condition using the prop. It was decided the comment was enough but I am putting the redundant if-condition back to be ultra specific for readers of the code – the interim period where we're faking some events, but not when the experimental flag is on, is admittedly a bit confusing.

Author has addressed the following

• Tests
  • [ ] TODO (before merge)
  • [ ] Included
  • [x] Not necessary because: tested by existing tests
• E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • [ ] I don't know
  • [x] Required / Maybe required
  • [ ] Not required because:
• Changeset (Changeset guidelines)
  • [ ] TODO (before merge)
  • [ ] Included
  • [x] Not necessary because: no change in behaviour
• Public documentation
  • [ ] TODO (before merge)
  • [ ] Cloudflare docs PR(s):
  • [x] Not necessary because:

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 6bc3279da3d30adf970ac4ccf18824ff14ebe5c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions[bot]]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9612656803/npm-package-wrangler-6116

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6116/npm-package-wrangler-6116

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9612656803/npm-package-wrangler-6116 dev path/to/script.js

Additional artifacts:

```sh npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9612656803/npm-package-create-cloudflare-6116 --no-auto-update ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9612656803/npm-package-cloudflare-kv-asset-handler-6116 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9612656803/npm-package-miniflare-6116 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9612656803/npm-package-cloudflare-pages-shared-6116 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9612656803/npm-package-cloudflare-vitest-pool-workers-6116 ``` Note that these links will no longer work once [the GitHub Actions artifact expires](https://docs.github.com/en/organizations/managing-organization-settings/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-organization).

---

wrangler@3.61.0 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20240610.1
workerd	1.20240610.1	1.20240610.1
workerd --version	1.20240610.1	2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[penalosa]

This seems likely to cause more confusion to me—can we at least retain the comment?

[petebacondarwin]

This seems likely to cause more confusion to me—can we at least retain the comment?

There is a comment down where onBundleStart() is called. I guess there is no chance that the experimentalDevEnv can change at runtime? If it can then it seems that this is a reasonable check to have in place?

[RamIdeas]

I guess there is no chance that the experimentalDevEnv can change at runtime? If it can then it seems that this is a reasonable check to have in place?

It definitely does not change. This check is kind of redundant but also we don't want these events being faked if the real events are being used

We can remove the check and dependency array item entirely or keep it. I don't mind either way. The intent of this PR is to remove the lint warning.