cloudflare / workers-sdk

⛅️ Home to Wrangler, the CLI for Cloudflare Workers®
https://developers.cloudflare.com/workers/
Apache License 2.0
2.41k stars 590 forks source link

ConfigController minor internal renaming #6145

Closed RamIdeas closed 5 days ago

RamIdeas commented 5 days ago

What this PR solves / how to test

Some minor internal refactors to the config controller, addressing some comments from a previous PR where the relevant diff was cherry-picked into another PR and merged before the comments had been addressed

Author has addressed the following

changeset-bot[bot] commented 5 days ago

⚠️ No Changeset found

Latest commit: 2e10edeff1e494779262beafb51c752db6ab5acd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 5 days ago

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664658178/npm-package-wrangler-6145

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6145/npm-package-wrangler-6145

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664658178/npm-package-wrangler-6145 dev path/to/script.js
Additional artifacts: ```sh npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664658178/npm-package-create-cloudflare-6145 --no-auto-update ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664658178/npm-package-cloudflare-kv-asset-handler-6145 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664658178/npm-package-miniflare-6145 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664658178/npm-package-cloudflare-pages-shared-6145 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664658178/npm-package-cloudflare-vitest-pool-workers-6145 ``` Note that these links will no longer work once [the GitHub Actions artifact expires](https://docs.github.com/en/organizations/managing-organization-settings/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-organization).

wrangler@3.62.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240620.0
workerd 1.20240620.1 1.20240620.1
workerd --version 1.20240620.1 2024-06-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

hossain666 commented 5 days ago

abb21a9b5954e44c5689abb76d921e42f9aca605[****]()