cloudflare / workers-sdk

⛅️ Home to Wrangler, the CLI for Cloudflare Workers®
https://developers.cloudflare.com/workers/
Apache License 2.0
2.41k stars 590 forks source link

remove extra quote from pages deploy message #6159

Closed dario-piotrowicz closed 3 days ago

dario-piotrowicz commented 3 days ago

What this PR solves / how to test

Just fixing a typo I noticed when running wrangler pages deploy

Author has addressed the following

changeset-bot[bot] commented 3 days ago

⚠️ No Changeset found

Latest commit: bc719b8d8dc999a5d36778863d130f4a46aee900

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 3 days ago

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9695301620/npm-package-wrangler-6159

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6159/npm-package-wrangler-6159

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9695301620/npm-package-wrangler-6159 dev path/to/script.js
Additional artifacts: ```sh npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9695301620/npm-package-create-cloudflare-6159 --no-auto-update ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9695301620/npm-package-cloudflare-kv-asset-handler-6159 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9695301620/npm-package-miniflare-6159 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9695301620/npm-package-cloudflare-pages-shared-6159 ``` ```sh npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9695301620/npm-package-cloudflare-vitest-pool-workers-6159 ``` Note that these links will no longer work once [the GitHub Actions artifact expires](https://docs.github.com/en/organizations/managing-organization-settings/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-organization).

wrangler@3.62.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240620.0
workerd 1.20240620.1 1.20240620.1
workerd --version 1.20240620.1 2024-06-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

dario-piotrowicz commented 3 days ago

Will this break a test?

oh.... I didn't think of that....

I can't see the string being tested anywhere: Screenshot 2024-06-27 at 13 06 54

So I think that it should be fine 🙂