export function add(a: number, b: number): number {
return a + b;
}
a Pages Function math-is-fun.ts, which imports ../math/add.ts and calls add()
When we run pages dev with this project setup, any changes made to the add.ts file will trigger Functions to rebuild. This works as expected.
Now imagine we delete the contents of add.ts (not the file itself!!) but leave everything else as it is. In the terminal, we'll get a compile warning saying Import "add" will always be undefined because the file "../math/add.ts" has no exports which is what is expected.
At this point, IMHO, add.ts is technically still a dependency of math-is-fun.ts (but happy to hear what others think), since it is still imported in the Functions code. My expectation in this case, would be that if we were to undo the changes we made in add.ts, that would trigger a Functions rebuild as well. This works as expected if esbuild was in watch mode, but it does not trigger anything in the current implementation.
The reason for that is that the metafile returned by esbuild does list add.ts as an input, but it does not list it as an input to the entrypoint, which means we won't return it as part of bundle.dependecies 😕. The returned metafile BTW, looks exactly the same in both esbuild/chokidar watch modes. So, it's either that esbuild watches more files than what it returns in the metafile, or we're making some wrong assumptions when we process that metafile to return bundle.dependencies, or there is a plugin somewhere that strips out empty imports? (meaning of 0kb in size).
Whatever it is, the finding is a tad worrying...cause it makes me wonder...what other corner cases I didn't think of yet, would result in a similar behaviour 🫠 ... and can we really rely on bundle.dependencies as a correct source of truth?
Which Cloudflare product(s) does this pertain to?
Pages
What version(s) of the tool(s) are you using?
3.63
What version of Node are you using?
18.20.0
What operating system and version are you using?
MacOS Sonoma 14.4.1
Describe the Bug
Say we have the following:
math/add.tsmath-is-fun.ts, which imports../math/add.tsand callsadd()When we run
pages devwith this project setup, any changes made to theadd.tsfile will trigger Functions to rebuild. This works as expected.Now imagine we delete the contents of
add.ts(not the file itself!!) but leave everything else as it is. In the terminal, we'll get a compile warning sayingImport "add" will always be undefined because the file "../math/add.ts" has no exportswhich is what is expected.At this point, IMHO,
add.tsis technically still a dependency ofmath-is-fun.ts(but happy to hear what others think), since it is still imported in the Functions code. My expectation in this case, would be that if we were to undo the changes we made inadd.ts, that would trigger a Functions rebuild as well. This works as expected if esbuild was in watch mode, but it does not trigger anything in the current implementation.The reason for that is that the metafile returned by esbuild does list
add.tsas aninput, but it does not list it as an input to the entrypoint, which means we won't return it as part ofbundle.dependecies😕. The returned metafile BTW, looks exactly the same in both esbuild/chokidar watch modes. So, it's either that esbuild watches more files than what it returns in the metafile, or we're making some wrong assumptions when we process that metafile to returnbundle.dependencies, or there is a plugin somewhere that strips out empty imports? (meaning of 0kb in size).Whatever it is, the finding is a tad worrying...cause it makes me wonder...what other corner cases I didn't think of yet, would result in a similar behaviour 🫠 ... and can we really rely on
bundle.dependenciesas a correct source of truth?Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
No response