search

cloudflare / workers-types

TypeScript type definitions for authoring Cloudflare Workers.
BSD 3-Clause "New" or "Revised" License
359 stars 89 forks source link

(3.18.0) IncomingRequestCfPropertiesGeographicInformation is the wrong type #313

Closed davemurphysf closed 1 year ago

davemurphysf commented 1 year ago

Because IncomingRequestCfProperties is a union, you can't pass an empty object as a possible type for IncomingRequestCfPropertiesGeographicInformation. Instead, all properties should be marked as optional and the country parameter should be type country: Iso3166Alpha2Code | "T1";

philipatkinson commented 1 year ago

Probably should have initially named the title in the pull request more explicitly (have done so now), but #310 is exactly that fix.

davemurphysf commented 1 year ago

Awesome! Thank you, closing.