Closed swr closed 4 years ago
kristianfreeman
commented
4 years ago hey @swr, was hoping that me clicking the "Update branch" button would fire off a build on our repo so the status check would work. it seems like we actually receive so few PRs from outside the cf organization that we don't actually have builds for those kinds of PRs set up - oops! regardless, this looks good to me (tested locally) and i'm merging now. thanks so much!
swr
commented
4 years ago Thanks. Should be all set. Great catches and tweaks. I think Sites is a great place for a lot of people to get to play with Cloudflare Workers, so making the onboarding easy was a great idea! I was literally trying to get a splash page up in as little time as possible and had been wanting to play with workers so it worked out great. Even with a fresh start it was quicker and friendlier than firebase in a lot of ways. Almost a netlify.
No worries on the build stuff, understood.
API Tokens via the profile page are the recommended auth path by the wrangler config cli and good security hygiene. It can be confusing when a new user is looking to try Sites.
Update language and instructions to direct them to create a limited token with just Workers permissions via the Workers template.
If Global API Key is still desired for the quickstart the link to the profile should be updated at least so that it points to the API section of the updated profile section.
Fixes Issues #122