cloudflare / wrangler-action

🧙‍♀️ easily deploy cloudflare workers applications using wrangler and github actions
Apache License 2.0
1.18k stars 152 forks source link

Swap CF_API_TOKEN with CLOUDFLARE_API_TOKEN #204

Closed jgentes closed 11 months ago

jgentes commented 11 months ago

If the token isn't specified, wrangler throws this error, indicating the CLOUDFLARE_API_TOKEN should be set, so it's worth being consistent so folks can copy/paste the examples and have it work out of the box:

In a non-interactive environment, it's necessary to set a CLOUDFLARE_API_TOKEN environment variable for wrangler to work.
jacobbednarz commented 11 months ago

lgtm - we should also do the same update for CLOUDFLARE_ACCOUNT_ID (previously CF_ACCOUNT_ID).

jgentes commented 11 months ago

Hey Pete! :) I've been promoting Workers within Procore - I even gave a demo of using D1 & KV with Pages + Functions to show off how simple it is to create stateful applications. Fun stuff, keep up the great work!

1000hz commented 11 months ago

This looks good to me, though @jgentes would you mind updating CF_ACCOUNT_ID as @jacobbednarz suggested? Once that's done I'll go ahead and merge.

jgentes commented 11 months ago

done!

1000hz commented 11 months ago

Thanks @jgentes!