cloudflare / wrangler-action

🧙‍♀️ easily deploy cloudflare workers applications using wrangler and github actions
Apache License 2.0
1.26k stars 159 forks source link

Support KV namespaces creating/binding #239

Closed johnd0e closed 5 days ago

johnd0e commented 8 months ago

I want to use some github repo as template, with deploy button.

The problem is the original repo uses KV and has kv_namespace hardcoded in wrangler.toml. So no surprize that wrangler-action fails:

Possible solution:

The last step looks not clean for me, perhaps better would be to refer namespaces in other ways. E.g.:

carafelix commented 5 months ago

Is there a way to not depend on wrangler.toml to bind the kv namespace?

shakibhasan09 commented 3 months ago

Want to know too!

jahands commented 5 days ago

Hi! This looks like it's an issue with workers-sdk and not wrangler-action. While it's technically feasible to implement this within wrangler-action, it would likely be brittle and be confusing due to differing behavior from wrangler.

If this is a feature you're interested in, please create a feature request in workers-sdk

Thanks!