cloudflare / wrangler-action

🧙‍♀️ easily deploy cloudflare workers applications using wrangler and github actions
Apache License 2.0
1.24k stars 158 forks source link

uploading environment secrets doesn't work with pages deploy #304

Open qqpann opened 2 weeks ago

qqpann commented 2 weeks ago

https://github.com/cloudflare/wrangler-action/blob/cd8a317efbc7fab418e9bd7092c8643d88c03321/src/index.ts#L251

When the repository is pages directory, it needs to run

wrangler pages secret bulk

Otherwise it will run into the following error:

🔑 Uploading secrets...
  /opt/hostedtoolcache/node/18.20.4/x64/bin/npx wrangler secret:bulk

   ⛅️ wrangler 3.81.0
  -------------------

  ✘ [ERROR] It looks like you've run a Workers-specific command in a Pages project.

    For Pages, please run `wrangler pages secret bulk` instead.

  🪵  Logs were written to "/home/runner/.config/.wrangler/logs/wrangler-2024-10-20_12-06-13_693.log"
  Error: The process '/opt/hostedtoolcache/node/18.20.4/x64/bin/npx' failed with exit code 1
Error: Failed to upload secrets.
Error: 🚨 Action failed
ckhicks commented 1 week ago

This appears to be throwing errors on Worker deploys, too.

🔑 Uploading secrets...
  /usr/local/bin/npx wrangler secret:bulk
   ⛅️ wrangler 3.78.10 (update available 3.83.0)
  ----------------------------------------------
  ▲ [WARNING] `wrangler secret:bulk` is deprecated and will be removed in a future major version.
    Please use `wrangler secret bulk` instead, which accepts exactly the same arguments.
  🌀 Creating the secrets for the Worker "[redacted]" 
  Finished processing secrets JSON file:
  ✨ 0 secrets successfully uploaded
  ✘ [ERROR] 🚨 3 secrets failed to upload

Using: actions/checkout@v4 & cloudflare/wrangler-action@v3