search

cloudflare / wrangler-action

🧙‍♀️ easily deploy cloudflare workers applications using wrangler and github actions
Apache License 2.0
1.27k stars 160 forks source link

Release 3.10.0 fails when getting ${{ steps.deploy.outputs.deployment-url }} #307

Closed cawauchi6204 closed 3 weeks ago

cawauchi6204 commented 1 month ago

Description

I've started seeing the following failures with the latest release:

- name: Deploy
  id: deploy
  uses: cloudflare/wrangler-action@v3
  with:
    apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
    accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
    command: pages deploy --project-name=example --branch=${{ inputs.branch-name }}

- name: print deployment-url
  env:
    DEPLOYMENT_URL: ${{ steps.deploy.outputs.deployment-url }}
  run: echo $DEPLOYMENT_URL

output

and I pined 

  uses: cloudflare/wrangler-action@v3.9.0

and it was success.

tsukimizake commented 1 month ago

On pages publish and pages deploy, deployment-url seems to be renamed to url. https://github.com/cloudflare/wrangler-action/pull/303/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R369

tiangolo commented 1 month ago

I made an initial PR to handle it here: https://github.com/cloudflare/wrangler-action/pull/308, but it doesn't include tests, maybe they would want to add them or use the initial idea to fix it in a different way. :nerd_face: