search

cloudflare / wrangler-action

🧙‍♀️ easily deploy cloudflare workers applications using wrangler and github actions
Apache License 2.0
1.26k stars 159 forks source link

Use wrangler deploy artifacts for deployment URLs #311

Open tsteckenborn opened 1 month ago

tsteckenborn commented 1 month ago

Hi all, I was wondering why I see some of my environment variables as deployment urls. I would argue that the coding here is not robust enough as I now always get, for example, the posthog endpoint I set as a variable (because it may be us or eu) as my deployment url:

https://github.com/cloudflare/wrangler-action/blob/b2be7abbfc024e06516af00e22260d4b6edcce53/src/index.ts#L343-L349

Would be nice if this could be improved.

nprogers commented 1 week ago

This is a bug where wrangler-action is picking up the first url listed in environment variables. We need to create a PR to use deployment metadata instead. Updating this issue to reflect what work needs to be done.