search

cloudflare / wrangler-action

🧙‍♀️ easily deploy cloudflare workers applications using wrangler and github actions
Apache License 2.0
1.26k stars 159 forks source link

Wragler action 3.12 returns incorrect deployment URL #317

Closed Pante closed 2 weeks ago

Pante commented 2 weeks ago

I have the following workflow which deploys two related projects to separate domains before subsequently posting the latter project's URL on a GitHub comment, https://github.com/forus-labs/forui/actions/runs/11682147658/workflow?pr=174#L75.

After 3.12 was released, we noticed that the URL being posted was incorrect. Instead of posting the latter project's URL, it posted the first project's. It seems like the deployment-url isn't being updated after the action is called the for the first time.

Incorrect URL using 3.12: https://github.com/forus-labs/forui/pull/174#issuecomment-2432064082

Correct URL after reverting to 3.11: https://github.com/forus-labs/forui/pull/254#issuecomment-2454071044

Maximo-Guk commented 2 weeks ago

Hi @Pante , can you confirm that the 3.12.1 release fixed this for you?

Pante commented 2 weeks ago

Seems to be working now. Thanks for the quick fix!