Closed Maximo-Guk closed 2 days ago
Do not merge until:
I like having all the github logic into one file!
Great to see this happening!
I contributed some of the Pages action's features, and I have a few suggestions to avoid repeating some of its mistakes:
Don't require GitHub token as an action input. Default its value to github.token
(see actions/checkout
for a great example), then let users turn features on/off using boolean inputs. This is a lot less confusing and aligns with the rest of the ecosystem.
Accept environment name as input. Named GitHub environments can hold configurations, so migrating users might need this action's environment names to match their old ones, so that those configurations will still apply. And one repo can deploy multiple Wrangler apps, so their environment names must be configurable or else they will collide.
Provide separate inputs to enable deployments vs. job summaries. Deployments add a lot of noise on the Conversation tab, whereas job summaries add a lot of noise on the Checks tab. Ideally users could choose how much noise they want.
Great to see this happening!
I contributed some of the Pages action's features, and I have a few suggestions to avoid repeating some of its mistakes:
- Don't require GitHub token as an action input. Default its value to
github.token
(seeactions/checkout
for a great example), then let users turn features on/off using boolean inputs. This is a lot less confusing and aligns with the rest of the ecosystem.- Accept environment name as input. Named GitHub environments can hold configurations, so migrating users might need this action's environment names to match their old ones, so that those configurations will still apply. And one repo can deploy multiple Wrangler apps, so their environment names must be configurable or else they will collide.
- Provide separate inputs to enable deployments vs. job summaries. Deployments add a lot of noise on the Conversation tab, whereas job summaries add a lot of noise on the Checks tab. Ideally users could choose how much noise they want.
Thanks a lot Aaron! I'm going to implement those changes in a separate PR as this PR is already getting to be pretty big!
Addresses #301
This PR updates
wrangler-action
dependencies and adds@actions/github
, so that we can create GitHub deployments, as well as job summaries when a user provides their GiHub token to the action config.Github deployments successfully tested here:
Job summary successfully tested here