cloudflarearchive / backgrid

Finally, an easily stylable semantic HTML data grid widget with a Javascript API that doesn't suck.
http://backgridjs.com
MIT License
2.01k stars 325 forks source link

Column header cell's become buttons #667

Open rorgonas opened 7 years ago

rorgonas commented 7 years ago

After the last build update from v0.3.7 to v0.3.8 our header cell's become buttons.

Checked in commit. We can see following changes:

  1. lib/backgrid.css: header cells element selector has been changes
 @@ -62,8 +62,11 @@
    background-color: #f9f9f9;
  }

 -.backgrid thead th a {
 +.backgrid thead th button {
    display: block;
 +  padding: 0;
 +  background: none;
 +  border: none;
  }
  1. api/output/Backgrid.HeaderCell.js <code>{&quot;click button&quot;: &quot;onClick&quot;}</code>

Please confirm if this is a bug or a new feature. Thank.

daneshka commented 7 years ago

This is not a bug fix. You shouldn't release this feature as a bug fix. 0.3.8 just broke our release in the last day 😞

mr-feek commented 7 years ago

0.3.8 is not backwards compatible. It broke my app. Please fix and bump minor version.