coveralls
commented
3 years ago Pull Request Test Coverage Report for Build 436631146
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 40 of 46 (86.96%) changed or added relevant lines in 4 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage increased (+36.0%) to 47.439%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| odoh_server.go | 0 | 1 | 0.0% | ||
| resolver.go | 0 | 1 | 0.0% | ||
| target.go | 36 | 40 | 90.0% | ||
| <!-- | Total: | 40 | 46 | 86.96% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| target.go | 1 | 72.46% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 430888209: | 36.0% |
| Covered Lines: | 213 |
| Relevant Lines: | 449 |
chris-wood
tanyav2
This is just a start of the relevant code paths. We might consider just removing telemetry, or creating a specialized target implementation that uses it, so the default code path is more lean.