coveralls
commented
3 years ago Pull Request Test Coverage Report for Build 424727693
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
- 24 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.05%) to 11.066%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| odoh_server.go | 0 | 6 | 0.0% | ||
| <!-- | Total: | 0 | 6 | 0.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| odoh_server.go | 24 | 0.0% | ||
| <!-- | Total: | 24 | --> |
| Totals | |
|---|---|
| Change from base Build 424676131: | -0.05% |
| Covered Lines: | 54 |
| Relevant Lines: | 488 |
Currently, both proxy and target listened on
/dns-query. This changes them to listen on/proxyand/dns-queryrespectively. Currently,indexHandlerwas usingr.URL.Hostname()andr.URL.Port(), but for client requests, these are not set. So that has been updated to user.Host(which includes port).