lib: fix WIT API file location.

PI-Victor commented 2 months ago

Set the location to a symlink instead of a relative path. Also the CI now clones the skyforge repo to build on the latest spec.

Summary by CodeRabbit

Chores
- Updated Rust workflow configuration to clone Skyforge repository.
- Cleaned up .gitignore to remove plugins-interface.json and added wit.
Refactor
- Removed once_cell dependency from Cargo.toml.
- Simplified Makefile by removing the get-spec target.
- Updated the path in bindgen! macro for consistency.

cloudflare-pages[bot] commented 2 months ago

Deploying skycrane with Cloudflare Pages

Latest commit:	`97a97f8`
Status:	✅ Deploy successful!
Preview URL:	https://69330bf5.skycrane.pages.dev
Branch Preview URL:	https://fix-github-actions.skycrane.pages.dev

View logs

PI-Victor commented 2 months ago

/assign /approve

coderabbitai[bot] commented 2 months ago

Walkthrough

The recent changes streamline the Rust project's workflow by integrating the Skyforge repository directly and adjusting the file paths for the wit API. Additionally, obsolete dependencies and targets have been removed, simplifying the project's structure and dependencies, while ensuring the .gitignore file reflects the current project needs.

Changes

Files	Change Summary
`.github/…/rust.yml`	Added a step to clone Skyforge repository and copy the wit API
`.gitignore`	Removed `plugins-interface.json` and added `wit` to the ignore list
`Cargo.toml`	Removed dependency on `once_cell` version 1.19.0
`Makefile`	Removed the `get-spec` target and its commands, streamlining build and clean targets
`src/lib.rs`	Updated the `bindgen!` macro path from `"../skyforge/spec/wit"` to `"wit"`

Poem

🐇✨

In the code's bustling weave, a change arose, Skyforge now in our Rust flows. Once cells now free, no longer keep, We dance in code, in joy we sweep. Bindgen aligns, the path made clear, In git’s embrace, no wit to fear.

So hop along, in harmony, For coding joy, we'll always see.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

PI-Victor commented 2 months ago

/triage

PI-Victor commented 2 months ago

fixes: https://github.com/cloudflavor/skycrane/issues/28

PI-Victor commented 2 months ago

/merge

cloudflavor / skycrane